Re: [PATCH V2] regulator: tps6586x: register regulator even if noinit data

From: Laxman Dewangan
Date: Thu Sep 06 2012 - 07:54:49 EST


On Wednesday 05 September 2012 09:03 PM, Stephen Warren wrote:
On 09/05/2012 02:02 AM, Laxman Dewangan wrote:
On Wednesday 05 September 2012 02:17 AM, Stephen Warren wrote:
On 08/29/2012 09:01 AM, Laxman Dewangan wrote:
Register all TPS6586x regulators even if there is no regulator
init data for platform i.e. without any user-supplied constraints.

Signed-off-by: Laxman Dewangan<ldewangan@xxxxxxxxxx>
Tested-by: Stephen Warren<swarren@xxxxxxxxxx>

Note that this patch depends on the patch I just posted titled
"regulator: tps6586x: add support for SYS rail". I also believe Laxman
will be posting another patch based on these 2 soon (it will move the
regulator DT parsing out of the MFD driver into the regulator driver),
so I guess it makes sense to take them all through the same TPS6586x
topic branch in the regulator tree.
About next patch (moving regulator dt parsing out of mfd), do you want
to support the Harmony also?
If yes then same change should also contain the board-harmony-power.c
changes.
Yes, Harmony needs to continue working.

We can either:

a) Add your third patch to the TPS6586x topic branch in the regulator
tree, and I'll merge all 3 into the Tegra tree in order to build on it
and switch the regulators to DT.

b) You can wait to submit your third patch until after the 3.7 merge
window (i.e. send if for 3.8) since then all the dependencies will have
appeared in Linus's tree as a baseline. This is probably the simplest.

I will go with option (b) as this is just enhancement and not any critical bug fixes.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/