Re: [PATCH] [mcelog] Start using the new sysfs tunables location

[Alan Cox]

On Thu, 06 Sep 2012 18:04:27 +0530
"Naveen N. Rao" <naveen.n.rao@xxxxxxxxxxxxxxxxxx> wrote:

> On 09/06/2012 05:58 PM, Andi Kleen wrote:
> >> The change is still under discussion. Stage one is to add the new global
> >> pathnames in addition to keeping the old per-cpu ones. Also fix all utilities
> >> (just mcelog(8) as far as we know) to prefer the new paths.
> >
> > But why do you even want to change it?  Does it fix anything?
> > AFAIK the old setup -- while not being pretty -- works just fine.
> 
> The reason for this was explained in this thread:
> http://www.mail-archive.com/linux-kernel@xxxxxxxxxxxxxxx/msg298302.html
> 
> Even if we decide not to remove these tunables from under their current 
> per-cpu location, I still think it is much cleaner to have them 
> available under /sys/devices/system/machinecheck.

That to me seems a ridiculous proposal. What are you going to do if in
future they ceased to be system wide ? Move them back ?

The threshold for playing musical chairs with sysfs nodes is a lot higher
than "I think it's much cleaner"

The current approach is a lot more futureproof even if a spot more ugly.

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/