Re: [PATCH v6] uartclk value from serial_core exposed to sysfs

[Tomas Hlavacek]

Hi Jiri,

On Thu, Sep 6, 2012 at 7:54 PM, Jiri Slaby <jslaby@xxxxxxx> wrote:
> On 09/06/2012 03:17 AM, Tomas Hlavacek wrote:
>> @@ -2362,8 +2392,8 @@ int uart_add_one_port(struct uart_driver *drv, struct uart_port *uport)
>>        * Register the port whether it's detected or not.  This allows
>>        * setserial to be used to alter this ports parameters.
>>        */
>> -     tty_dev = tty_port_register_device(port, drv->tty_driver, uport->line,
>> -                     uport->dev);
>> +     tty_dev = tty_register_device_attr(drv->tty_driver, uport->line,
>> +                     uport->dev, port, tty_dev_attr_groups);
>
> This makes me believe you have not tested the change at all?

Thanks! I can't believe I missed that. (And I actually tested that,
but I have to admit that it was not enough apparently.)

I will re-send the patch (after some additional testing and double-checking).

Tomas
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/