Re: [PATCH V3] regulator: disable supply regulator if it is enabledfor boot-on

[Mark Brown]

On Mon, Sep 03, 2012 at 07:55:39PM +0530, Laxman Dewangan wrote:

> +	/* If supply enabled during registrtaion then need to disable
> +	 * when full constraint enabled.
> +	 */
> +	unsigned int need_supply_disable:1;

I don't understand why we need this flag.  Shouldn't we just be making
the reference counts for the supplies correct and then have the
regulator disabled in the late initcall as a result of its refcount
falling to zero when the children are disabled?  I think what we need to
do here is always take a reference to the supply if the child is enabled
during boot, then in the initcall we can just disable the parent
regulator as normal.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/