Re: [PATCH] ARM: ep93xx: Fix build error due to 'SZ_32M' undeclared
From: Axel Lin
Date: Fri Sep 07 2012 - 01:49:10 EST
> Hi Axel,
>
> The patch looks fine. I notice that the other ep93xx boards are also
> using the SZ_ defines, but are indirectly including linux/sizes.h via
> asm/memory.h, which in turn is indirectly included via asm/io.h. That
Seems this is also true for other platforms ( e.g. mach-pxa, mach-ux500, etc)
> seems a bit flaky, so I wonder if we should just explicitly include
> <linux/sizes.h> in all the board files which use the SZ_ macros as per
> the patch below. Thoughts?
I'm 50/50 on this.
But if we do these changes, this patch is more than a build fix.
Regards,
Axel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/