Re: [PATCH] x86, efi: 1:1 pagetable mapping for virtual EFIcalls

[Jan Beulich]

>>> On 06.09.12 at 17:47, Matt Fleming <matt.fleming@xxxxxxxxx> wrote:
> On Thu, 2012-09-06 at 15:34 +0100, Jan Beulich wrote:
>> >>> On 06.09.12 at 15:15, Matt Fleming <matt@xxxxxxxxxxxxxxxxx> wrote:
>> > +	__flush_tlb_all();
>> 
>> Is it certain you will _never_ hit a global mapping (in which case I
>> believe the above would be insufficient)?
> 
> Are you saying that this should be a flush_tlb_all() if we have global
> mappings? Or that if we are guaranteed to never have global mappings we
> can opitmise this by simply doing a __flush_tlb()?

Hmm, looks like I shouldn't have worked from memory -
other than I remembered, __flush_tlb_all() does take care
of global pages. But indeed, if we can be sure that no global
mappings would ever exist in the replaced (low) part of the
address space, then __flush_tlb() would be sufficient. But I
would agree that for a first round (and possibly forever,
particularly as long as performance doesn't matter) it's safer
to use the more aggressive flush. So please disregard my
respective comment to that part of your patch.

Jan

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/