Re: [PATCH 07/12] perf diff: Add ratio computation way to comparehist entries

[Jiri Olsa]

On Fri, Sep 07, 2012 at 02:45:28PM +0900, Namhyung Kim wrote:
> On Thu,  6 Sep 2012 17:47:01 +0200, Jiri Olsa wrote:
> > Adding -c option to select computation method with the current
> > 'Delta' computation as default. Current posible values are of
> > this option are: 'delta' and 'ratio'.
> >

SNIP

> > @@ -263,6 +296,8 @@ static const struct option options[] = {
> >  		    "Show position displacement relative to baseline"),
> >  	OPT_BOOLEAN('b', "baseline-only", &show_baseline_only,
> >  		    "Show only items with match in baseline"),
> > +	OPT_STRING('c', "compute", &compute_str, "delta,ratio (default delta)",
> > +		   "Entries differential computation selection"),
> 
> Why not make it OPT_CALLBACK?
> 
right, thanks

jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/