Re: [PATCH 04/19] ARM: ux500: Add SDI (MMC) support to the HREFDevice Tree

From: Lee Jones
Date: Fri Sep 07 2012 - 08:39:19 EST


On Fri, Sep 07, 2012 at 12:29:31PM +0000, Arnd Bergmann wrote:
> On Friday 07 September 2012, Lee Jones wrote:
> > + // External Micro SD slot
> > + sdi@80126000 {
> > + arm,primecell-periphid = <0x10480180>;
> > + max-frequency = <50000000>;
> > + bus-width = <8>;
> > + mmc-cap-sd-highspeed;
> > + mmc-cap-mmc-highspeed;
> > + vmmc-supply = <&ab8500_ldo_aux3_reg>;
> > +
> > + #gpio-cells = <1>;
> > + cd-gpios = <&gpio2 31 0x4>; // 95
> > +
> > + status = "okay";
> > + };
> > +
>
> The #gpio-cells property seems misplaced here.

Are you reading my patches in reverse order? ;)

If not, good spot. :)

--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/