Re: [PATCH 4/6] unicore32: Add common clock support

From: Thierry Reding
Date: Fri Sep 07 2012 - 08:53:37 EST


On Thu, Sep 06, 2012 at 04:42:06PM +0800, guanxuetao@xxxxxxxxxxxxxxx wrote:
> > This commit adds support for the common clock framework to the Unicore32
> > architecture.
> >
> > Signed-off-by: Thierry Reding <thierry.reding@xxxxxxxxxxxxxxxxx>
>
> This patch can't work.
> Could you disintegrate it into several small patches, so I could check it
> out.

I don't understand. How do you mean it can't work? Are you saying the
patch doesn't build, or does the system no longer boot properly? I don't
see how splitting it into smaller pieces is going to change anything
about that. Splitting it up also isn't going to work very well.
Conversion to the common clock framework is really all or nothing.

Thierry

Attachment: pgp00000.pgp
Description: PGP signature