Re: [RFC PATCH] ARM: OMAP2+: omap-device: Do not overwrite resourcesallocated by OF layer

[Benoit Cousson]

Hi Vaibhav,

The following patch is hacing some checkpatch issues. 

CHECK: Alignment should match open parenthesis
#169: FILE: arch/arm/plat-omap/omap_device.c:591:
+			dev_dbg(&pdev->dev, "%s(): resources already allocated %d\n",
+					__func__, res_count);

CHECK: Alignment should match open parenthesis
#171: FILE: arch/arm/plat-omap/omap_device.c:593:
+			memcpy(res, pdev->resource,
+				sizeof(struct resource) * pdev->num_resources);

CHECK: Alignment should match open parenthesis
#173: FILE: arch/arm/plat-omap/omap_device.c:595:
+			omap_device_fill_dma_resources(od,
+					&res[pdev->num_resources]);

CHECK: Alignment should match open parenthesis
#176: FILE: arch/arm/plat-omap/omap_device.c:598:
+			dev_dbg(&pdev->dev, "%s(): using resources from hwmod %d\n",
+					__func__, res_count);

total: 0 errors, 0 warnings, 4 checks, 130 lines checked


Since I was in a nice mood, because the week-end is almost there, I fixed them myself.

Please note that I had to rename the API becasue it was way too long to do a proper alignement.

 omap_device_fill_dma_resources -> _od_fill_dma_resources

In fact I realized that some private APIs should probably be renamed as well like that for
consistency.

Just let me know if you have any issue with that version.

Regards,
Benoit

---