Re: [PATCH 04/12] perf diff: Refactor diff displacement possitioninfo

[Arnaldo Carvalho de Melo]

Em Thu, Sep 06, 2012 at 05:46:58PM +0200, Jiri Olsa escreveu:
> @@ -150,6 +154,24 @@ static struct perf_evsel *evsel_match(struct perf_evsel *evsel,
>  	return NULL;
>  }
>  
> +static void resort_evlist(struct perf_evlist *evlist, bool name)

For consistency, please use:

+static void perf_evlist__resort_hists(struct perf_evlist *evlist, bool name)

> +{
> +	struct perf_evsel *evsel;
> +
> +	list_for_each_entry(evsel, &evlist->entries, node) {
> +		struct hists *hists = &evsel->hists;
> +
> +		hists__output_resort(hists);
> +
> +		/*
> +		 * The hists__name_resort only sets possition
> +		 * if name is false.
> +		 */
> +		if (name || ((!name) && show_displacement))
> +			hists__name_resort(hists, name);

- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/