Re: [PATCH -tip/perf/core ] perf probe: Allow of casting an array of char to string

[Namhyung Kim]

Hi Hyeoncheol,

Please CC the perf maintainers - at least Arnaldo for perf tools - next time.

Thanks,
Namhyung


On Tue, 11 Sep 2012 17:00:54 +0900, Hyeoncheol Lee wrote:
> Before casting a type of a variable to string,
> convert_variable_type() confirms that the type is a pointer or
> an array. then if it is a pointer to char, it is casted to string.
> but in case of an array of char, it isn't
>
> Cc: Masami Hiramatsu <masami.hiramatsu.pt@xxxxxxxxxxx>
> Cc: Srikar Dronamraju <srikar@xxxxxxxxxxxxxxxxxx>
> Signed-off-by: H.C. Lee <hyc.lee@xxxxxxxxx>
> ---
>  tools/perf/util/probe-finder.c |   10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/tools/perf/util/probe-finder.c b/tools/perf/util/probe-finder.c
> index d448984..94a00de 100644
> --- a/tools/perf/util/probe-finder.c
> +++ b/tools/perf/util/probe-finder.c
> @@ -413,12 +413,12 @@ static int convert_variable_type(Dwarf_Die *vr_die,
>                                    dwarf_diename(vr_die), dwarf_diename(&type));
>                         return -EINVAL;
>                 }
> +               if (die_get_real_type(&type, &type) == NULL) {
> +                       pr_warning("Failed to get a type"
> +                                  " information.\n");
> +                       return -ENOENT;
> +               }
>                 if (ret == DW_TAG_pointer_type) {
> -                       if (die_get_real_type(&type, &type) == NULL) {
> -                               pr_warning("Failed to get a type"
> -                                          " information.\n");
> -                               return -ENOENT;
> -                       }
>                         while (*ref_ptr)
>                                 ref_ptr = &(*ref_ptr)->next;
>                         /* Add new reference with offset +0 */
> --
> 1.7.1
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/