Re: [PATCH v3 11/31] arm64: IRQ handling

[Catalin Marinas]

On Fri, Sep 07, 2012 at 08:37:18PM +0100, Arnd Bergmann wrote:
> On Friday 07 September 2012, Catalin Marinas wrote:
> 
> > +#define __inc_irq_stat(cpu, member)	__IRQ_STAT(cpu, member)++
> > +#define __get_irq_stat(cpu, member)	__IRQ_STAT(cpu, member)
> 
> Isn't this something that the IRQ core code already keeps track of?

That's for the IPIs which are handled directly by the arch code. We
don't even allocate irq descriptors for them.

> > +#endif /* __ASM_HARDIRQ_H */
> > diff --git a/arch/arm64/include/asm/irq.h b/arch/arm64/include/asm/irq.h
> > new file mode 100644
> > index 0000000..a4e1cad
> > --- /dev/null
> > +++ b/arch/arm64/include/asm/irq.h
> > @@ -0,0 +1,8 @@
> > +#ifndef __ASM_IRQ_H
> > +#define __ASM_IRQ_H
> > +
> > +#include <asm-generic/irq.h>
> > +
> > +extern void (*handle_arch_irq)(struct pt_regs *);
> > +
> > +#endif
> 
> Is this one still needed?

Yes. It's initialised by the GIC code (called via of_irq_init) and we
want to allow different GIC versions (GICv2 used by the model currently
but we would expect GICv3 with hardware).

-- 
Catalin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/