Re: [PATCH v3 01/20] Input: Break out MT data

From: Henrik Rydberg
Date: Thu Sep 13 2012 - 13:50:54 EST


On Wed, Sep 12, 2012 at 10:15:28PM -0700, Dmitry Torokhov wrote:
> On Sat, Sep 01, 2012 at 09:46:56PM +0200, Henrik Rydberg wrote:
> > Move all MT-related things to a separate place. This saves some
> > bytes for non-mt input devices, and prepares for new MT features.
> >
> > Signed-off-by: Henrik Rydberg <rydberg@xxxxxxxxxxx>
> ...
> > @@ -1287,10 +1284,8 @@ struct input_dev {
> >
> > int rep[REP_CNT];
> >
> > - struct input_mt_slot *mt;
> > - int mtsize;
> > + struct input_mt *mt;
> > int slot;
> > - int trkid;
> >
> > struct input_absinfo *absinfo;
>
> Shouldn't 'slot' go into struct input_mt as well?

I wanted to remove it all together, but it turned out hairier than I
envisioned, so I left it for now. Once/if MT drivers are converted to
pass input_value arrays instead, 'slot' will disappear cleanly.

Henrik
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/