Re: [PATCH v2 4/4]: ezusb: move ezusb.c from drivers/usb/serial todrivers/usb/misc

From: Greg KH
Date: Fri Sep 14 2012 - 01:06:05 EST


On Thu, Sep 13, 2012 at 10:19:11PM +0200, Rene Buergel wrote:
> This patch moves drivers/usb/serial/ezusb.c to drivers/usb/misc/and
> adapts Makefiles and Kconfigs
>
> Signed-off-by: René Bürgel <rene.buergel@xxxxxxxxx>
> --
> diff --git a/drivers/usb/misc/Kconfig b/drivers/usb/misc/Kconfig
> index 1bfcd02..1c63b54 100644
> --- a/drivers/usb/misc/Kconfig
> +++ b/drivers/usb/misc/Kconfig
> @@ -244,3 +244,7 @@ config USB_YUREX
> To compile this driver as a module, choose M here: the
> module will be called yurex.
>
> +config USB_EZUSB
> + bool "Functions for loading firmware on EZUSB chips"
> + help
> + Say Y here if you need EZUSB device support.
> diff --git a/drivers/usb/misc/Makefile b/drivers/usb/misc/Makefile
> index 796ce7e..f1f7815 100644
> --- a/drivers/usb/misc/Makefile
> +++ b/drivers/usb/misc/Makefile
> @@ -11,6 +11,7 @@ obj-$(CONFIG_USB_CYPRESS_CY7C63) += cypress_cy7c63.o
> obj-$(CONFIG_USB_CYTHERM) += cytherm.o
> obj-$(CONFIG_USB_EMI26) += emi26.o
> obj-$(CONFIG_USB_EMI62) += emi62.o
> +obj-$(CONFIG_USB_EZUSB) += ezusb.o
> obj-$(CONFIG_USB_FTDI_ELAN) += ftdi-elan.o
> obj-$(CONFIG_USB_IDMOUSE) += idmouse.o
> obj-$(CONFIG_USB_IOWARRIOR) += iowarrior.o
> diff --git a/drivers/usb/misc/ezusb.c b/drivers/usb/misc/ezusb.c
> new file mode 100644
> index 0000000..867a3e1
> --- /dev/null
> +++ b/drivers/usb/misc/ezusb.c

Git should show this as a move, not as a "add a file and remove a file"
type patch. Are you generating it properly?

Also, why move it? Are there other modules that need to use it?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/