Re: [PATCH v2 0/3] Input: cyttsp4 - driver for Cypress TMA4XXtouchscreen devices

[Henrik Rydberg]

Hi Ferruh,

> This driver is for Cypress TrueTouch(tm) Standard Product controllers,
> Generation4 devices.
> 
> This is second version of driver, code re-structured to match with
> existing Generation3 driver code.

To integrate with the existing gen3 driver is clearly not the same as
creating a parallel set of files, which obviously share a lot of code
with the gen3 code.

For instance, the i2c transfer layer seems more or less identical to
the existing one; just look at cyttsp_i2c_write_block_data() versus
cyttsp4_i2c_write_block_data(). If different generations of device
data cannot even be transported through the same _generic_ interface,
something is clearly not right.

You can't seriously expect anyone to want to maintain one set of files
for every new version. Please make sure to build on what is already
there.

Thanks.
Henrik
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/