Re: [tip:x86/asm] x86: Prefer TZCNT over BFS

[Jan Beulich]

>>> On 17.09.12 at 12:00, Ingo Molnar <mingo@xxxxxxxxxx> wrote:
> Linus's suggestion is to introduce CONFIG_X86_TZCNT as an add-on 
> patch that cleans up and documents what this is all about.

It wasn't just this he complained about. Plus I don't think the
suggested name fits the current scheme - it would imply the
instruction to be available when set, yet that's explicitly _not_
a requirement. So X86_USE_TZCNT would seem a better fit
to me.

> Would you be willing to do such a patch?

If that was the only change needed, yes (hesitantly, as I
personally don't think introducing Kconfig options that have
only a single usage point is really useful). But the complaint
regarding this also getting enabled for old CPUs (which in
my understanding is the purpose of the GENERIC options)
is something that I wouldn't be willing to address (unless I'm
told these two options have another purpose), and thus I
would expect the resulting patch to still get vetoed by Linus
(which in essence means it would be wasted time to try to
address the other complaint).

Jan

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/