Re: Davicom DM9000C driver

[Arnd Bergmann]

On Wednesday 19 September 2012, Jonathan Corbet wrote:
> On Wed, 19 Sep 2012 13:58:08 +0800
> Allen Huang (éåæ)  <allen_huang@xxxxxxxxxxxxxx> wrote:
> 
> > I'm Allen Huang from Davicom. We are hereby opensourcing the linux
> > driver for our DM9000C. 
> 
> That is great, but please read the development process documentation on
> how best to submit something like this.  We would much rather see a patch
> (inline, not as an attachment) to facilitate the review.

More importantly, the patch should be against the version that is
already present in the kernel as drivers/net/ethernet/davicom/dm9000.c,
which appears to be mostly the same as the version that is submitted
here.

So while all the comments on the driver are valuable, they also apply
to the code we already have since 2005.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/