RE: [PATCH] pstore: avoid recursive spinlocks in theoops_in_progress case
From: Luck, Tony
Date: Thu Sep 20 2012 - 19:09:46 EST
> Mm... why break?
We don't know what the back-end driver will do if we allow another call
while a previous one is still in progress. It might end up corrupting the
backing non-volatile storage and losing some previously saved records.
Existing drivers (ERST and EFI) are dependent on f/w ... so things might
work on some platforms, yet be horribly bad on others.
The patch as it was written converts a deadlock (hang) case into a "lose
this log, but keep going" case. Which seems to be an improvement without
taking any risks about what the backend will do.
-Tony
¢éì®&Þ~º&¶¬+-±éÝ¥w®Ë±Êâmébìdz¹Þ)í
æèw*jg¬±¨¶Ýj/êäz¹Þà2Þ¨èÚ&¢)ß«a¶Úþø®G«éh®æj:+v¨wèÙ>W±êÞiÛaxPjØm¶ÿÃ-»+ùd_