Re: [Xen-devel] [PATCH v2] Persistent grant maps for xen blk drivers

From: Ian Campbell
Date: Mon Sep 24 2012 - 07:44:49 EST


On Mon, 2012-09-24 at 12:36 +0100, Jan Beulich wrote:
> >>> On 21.09.12 at 17:52, Oliver Chick <oliver.chick@xxxxxxxxxx> wrote:
> > Changes since v1:
> >
> > * Maximum number of persistent grants per device now 64, rather than
> > 256, as this is the actual maxmimum request in a (1 page) ring.
>
> As said previously, I don't see why this needs to have a separate
> #define at all - it's simply __RING_SIZE(). No adding this would
> also imply that - apart from perhaps documenting the new xenstore
> nodes - io/blkif.h would need changing at all (which otherwise would
> require a hypervisor side patch to be submitted too).

Whether or not this definition is required in blkif.h we certainly want
a patch to the hypervisor tree to document this new protocol extension.

Ian.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/