Re: [PATCH 22/30] perf tools: bfd.h/libbfd detection fails with recent binutils

[Mike Frysinger]

On Monday 24 September 2012 11:59:36 Arnaldo Carvalho de Melo wrote:
> --- a/tools/perf/Makefile
> +++ b/tools/perf/Makefile
>
> -		FLAGS_BFD=$(ALL_CFLAGS) $(ALL_LDFLAGS) $(EXTLIBS) -lbfd
> +		FLAGS_BFD=$(ALL_CFLAGS) $(ALL_LDFLAGS) $(EXTLIBS) -DPACKAGE='perf' -

in this case, if you were to expand PACKAGE, you'd get back the symbol perf 
(which most likely will be an error, but maybe it won't).  i think this should 
be instead:
	-DPACKAGE='"perf"'

> --- a/tools/perf/util/symbol.h
> +++ b/tools/perf/util/symbol.h
>
> +#define PACKAGE 'perf'

this isn't valid C anywhere.  pretty sure this should be:
	#define PACKAGE "perf"
-mike

Attachment: signature.asc
Description: This is a digitally signed message part.