Re: [PATCH] Update sched_domains_numa_masks when new cpus are onlined.

[Tang Chen]

Hi Peter~

I will make a v2 patch-set following your comments
and resent it soon. :)

Thanks. :)

On 09/25/2012 07:50 PM, Peter Zijlstra wrote:
> On Tue, 2012-09-25 at 19:45 +0800, Tang Chen wrote:
>
>
> > Let's have an example here.
> >
> > sched_init_numa()
> > {
> > 	...
> > 	// A loop set sched_domains_numa_levels to level.-------------1
> >
> > 	// I set sched_domains_numa_levels to 0.
> > 	sched_domains_numa_levels = 0;--------------------------------2
>
> Ah, ok, so this 'idiot in a hurry' (aka. me) placed the hunk wrong and
> thought it was at the start of the function.
>
> > 	// A loop allocating memory for sched_domains_numa_masks[][]
> > 	for (i = 0; i<  level; i++) {
> > 		......
> > 		// Allocate memory for sched_domains_numa_masks[i]----3
> > 		......
> > 	}
> > 	......
> >
> > 	// I reset sched_domains_numa_levels to level.
> > 	sched_domains_numa_levels = level;----------------------------4
> > }
>
> Yes this makes sense, it might be best to have this as a separate patch.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/