Re: [RFC PATCH 2/17] input: RMI4 core bus and sensor drivers.

[Christopher Heiny]

Sorry about the delay in following up on this one - we're going over the 
feedback, and realized we'd missed this comment.


On 08/23/2012 01:55 AM, Linus Walleij wrote:
> > +/* Create templates for given types */
> > >+#define simple_show_union_struct_unsigned(regtype, propname)\
> > >+simple_show_union_struct(regtype, propname, "%u\n")
> > >+
> > >+#define simple_show_union_struct_unsigned2(regtype, reg_group, propname)\
> > >+simple_show_union_struct2(regtype, reg_group, propname, "%u\n")
> > >+
> > >+#define show_union_struct_unsigned(regtype, reg_group, propname)\
> > >+show_union_struct(regtype, reg_group, propname, "%u\n")
> > >+
> > >+#define show_store_union_struct_unsigned(regtype, reg_group, propname)\
> > >+show_store_union_struct(regtype, reg_group, propname, "%u\n")
> > >+
> > >+#define show_repeated_union_struct_unsigned(regtype, reg_group, propname)\
> > >+show_repeated_union_struct(regtype, reg_group, propname, "%u")
> > >+
> > >+#define show_store_repeated_union_struct_unsigned(regtype, reg_group, propname)\
> > >+show_store_repeated_union_struct(regtype, reg_group, propname, "%u")
> > >+
> > >+/* Remove access to raw format string versions */
> > >+/*#undef simple_show_union_struct
> > >+#undef show_union_struct_unsigned
> > >+#undef show_store_union_struct
> > >+#undef show_repeated_union_struct
> > >+#undef show_store_repeated_union_struct*/
> This looks like trying to reimplement ioctl() in sysfs.
>
> If what you want is to send big structs in/out of the kernel,
> use either ioctl() on device nodes (should be trivial since input
> is using real device nodes) or use configfs.

I'm a little confused.  There's repeated emphasis in the kernel doc that 
you shouldn't use ioctl() anymore - use sysfs instead.  So we've been 
using sysfs, though it seems somewhat klutzy.  If it's actually OK to 
use ioctl(), that could simplify things.  On the other hand, using 
configfs might be more appropriate.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/