Re: [PATCH 09/57] power: ab8500_fg: usleep_range instead of shortmsleep

From: Anton Vorontsov
Date: Wed Sep 26 2012 - 22:39:21 EST


On Tue, Sep 25, 2012 at 10:12:06AM -0600, mathieu.poirier@xxxxxxxxxx wrote:
> From: Jonas Aaberg <jonas.aberg@xxxxxxxxxxxxxx>
>
> Signed-off-by: Jonas ABERG <jonas.aberg@xxxxxxxxxxxxxx>
> Signed-off-by: Mathieu Poirier <mathieu.poirier@xxxxxxxxxx>
> Reviewed-by: Johan BJORNSTEDT <johan.bjornstedt@xxxxxxxxxxxxxx>
> ---
> drivers/power/ab8500_fg.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/power/ab8500_fg.c b/drivers/power/ab8500_fg.c
> index 1e02b00..0db17c7 100644
> --- a/drivers/power/ab8500_fg.c
> +++ b/drivers/power/ab8500_fg.c
> @@ -957,7 +957,7 @@ static int ab8500_fg_load_comp_volt_to_capacity(struct ab8500_fg *di)
> do {
> vbat += ab8500_fg_bat_voltage(di);
> i++;
> - msleep(5);
> + usleep_range(5000, 5001);

Um.. why? From the commit message it's not obvious the rationale behind
this change. :-)

> } while (!ab8500_fg_inst_curr_done(di));
>
> ab8500_fg_inst_curr_finalize(di, &di->inst_curr);
> --
> 1.7.5.4
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/