Re: [PATCHv3 5/7] dmaengine: dw_dmac: add PCI part of the driver

[Felipe Balbi]

Hi,

On Thu, Sep 27, 2012 at 11:08:12AM +0300, Andy Shevchenko wrote:
> >> +     .is_private = 1,
> >> +     .chan_allocation_order = CHAN_ALLOCATION_ASCENDING,
> >> +     .chan_priority = CHAN_PRIORITY_ASCENDING,
> >> +};
> >
> > This is the same for all of the PCI IDs listed below, looks like it's
> > best to just add it as platform_data of the dwc_dmac device directly,
> > rather than passing a pointer to this via driver->data.
> It potentially could be altered. I prefer to leave it as structure in
> the pci driver.

fair enough ;-)

-- 
balbi

Attachment: signature.asc
Description: Digital signature