Re: [PATCHv2 00/14] perf diff: Factor diff command

[Andi Kleen]

On Thu, Sep 27, 2012 at 01:09:21PM +0200, Jiri Olsa wrote:
> hi,
> this is v2 of diff command changes proposed in here:
> https://lkml.org/lkml/2012/9/6/344
> 
> It's now rebased on new hists hpp* interface plus few
> more additional changes.

FWIW I've been playing around with it a bit. It seems useful
both for scaling problems and likely for performance regression tracking too.

Some minor issues I ran into (but no show stoppers):
- The error messages for bad -c expressions could be better
- I found the requirement for no space after -c unintuitive.
- It would be nice to have support for doing the bucketizing per line
instead of per function. With a large function and/or inlining 
it's sometimes hard to identify the actual problem
Acme recently added this for perf report.

I agree it would be good to merge.

-Andi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/