[PATCH] IB/lmx4: silence GCC warning
From: Paul Bolle
Date: Fri Sep 28 2012 - 08:48:54 EST
Building qp.o (part of the "Mellanox ConnectX HCA support" driver)
triggers this GCC warning:
drivers/infiniband/hw/mlx4/qp.c: In function âmlx4_ib_post_sendâ:
drivers/infiniband/hw/mlx4/qp.c:1828:30: warning: âvlanâ may be used uninitialized in this function [-Wmaybe-uninitialized]
drivers/infiniband/hw/mlx4/qp.c:1718:6: note: âvlanâ was declared here
Looking at the code it is clear 'vlan' is only set and used if 'is_eth'
is non-zero. But there's no harm in initializing 'vlan' to 0 (which
matches ib_get_cached_gid()'s default return) to silence GCC.
Signed-off-by: Paul Bolle <pebolle@xxxxxxxxxx>
---
0) I noticed this warning while building v3.6-rc7 on current Fedora 17,
using Fedora's default config.
1) Compile tested only. I tested against v3.6-rc7, with commit
a41262bb5721f2b708ee8b23f67be2f2e16a2fab ("IB/mlx4: SR-IOV IB context
objects and proxy/tunnel SQP") from linux-next cherry-picked, to take
into account a trivial context change in linux-next.
drivers/infiniband/hw/mlx4/qp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/infiniband/hw/mlx4/qp.c b/drivers/infiniband/hw/mlx4/qp.c
index a862251..71fdda6 100644
--- a/drivers/infiniband/hw/mlx4/qp.c
+++ b/drivers/infiniband/hw/mlx4/qp.c
@@ -1715,7 +1715,7 @@ static int build_mlx_header(struct mlx4_ib_sqp *sqp, struct ib_send_wr *wr,
int is_eth;
int is_vlan = 0;
int is_grh;
- u16 vlan;
+ u16 vlan = 0;
int err = 0;
send_size = 0;
--
1.7.11.4
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/