Re: [PATCH 01/16] iommu/amd: Keep track of HPET and IOAPIC device ids

[Joerg Roedel]

On Fri, Sep 28, 2012 at 10:08:34AM -0400, Konrad Rzeszutek Wilk wrote:
> On Fri, Sep 28, 2012 at 02:23:51PM +0200, Joerg Roedel wrote:
> > +	if (type != 1 && type != 2)
> > +		return -EINVAL;
> 
> Should this be perhaps an enum? or #define?

Yup, that'll be better. I change it.

> Reviwed-by: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>

Thanks!


	Joerg

-- 
AMD Operating System Research Center

Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach
General Managers: Alberto Bozzo
Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr. 43632

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/