Re: [PATCH 02/12] ata: mark probe function as __devinit rather than__init

[Mark Langsdorf]

On 09/28/2012 04:36 PM, Arnd Bergmann wrote:
> Functions for hotplugging must be marked as __devinit so
> they do not get discarded, as pointed out by a build time
> warning from modpost.
> 
> Cc: Mark Langsdorf <mark.langsdorf@xxxxxxxxxxx>
> Cc: Rob Herring <rob.herring@xxxxxxxxxxx>
> Cc: Jeff Garzik <jgarzik@xxxxxxxxxx>
> ---
>  drivers/ata/sata_highbank.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/ata/sata_highbank.c b/drivers/ata/sata_highbank.c
> index 0d7c4c2..36a141a 100644
> --- a/drivers/ata/sata_highbank.c
> +++ b/drivers/ata/sata_highbank.c
> @@ -260,7 +260,7 @@ static const struct of_device_id ahci_of_match[] = {
>  };
>  MODULE_DEVICE_TABLE(of, ahci_of_match);
>  
> -static int __init ahci_highbank_probe(struct platform_device *pdev)
> +static int __devinit ahci_highbank_probe(struct platform_device *pdev)
>  {
>  	struct device *dev = &pdev->dev;
>  	struct ahci_host_priv *hpriv;

Thanks. I just ran into this today and couldn't figure out the error
message.

Acked-by: Mark Langsdorf <mark.langsdorf@xxxxxxxxxxx>

--Mark Langsdorf
Calxeda, Inc.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/