Re: [RFC v9 PATCH 03/21] memory-hotplug: store the node id in acpi_memory_device

[Yasuaki Ishimatsu]

Hi Chen,

2012/09/28 12:21, Ni zhan Chen wrote:
> On 09/05/2012 05:25 PM, wency@xxxxxxxxxxxxxx wrote:
> > From: Wen Congyang <wency@xxxxxxxxxxxxxx>
> >
> > The memory device has only one node id. Store the node id when
> > enable the memory device, and we can reuse it when removing the
> > memory device.
>
> one question:
> if use numa emulation, memory device will associated to one node or ...?

Memory device has only one node, even if you use numa emulation.

Thanks,
Yasuaki Ishimatsu

> > CC: David Rientjes <rientjes@xxxxxxxxxx>
> > CC: Jiang Liu <liuj97@xxxxxxxxx>
> > CC: Len Brown <len.brown@xxxxxxxxx>
> > CC: Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx>
> > CC: Paul Mackerras <paulus@xxxxxxxxx>
> > CC: Christoph Lameter <cl@xxxxxxxxx>
> > Cc: Minchan Kim <minchan.kim@xxxxxxxxx>
> > CC: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> > CC: KOSAKI Motohiro <kosaki.motohiro@xxxxxxxxxxxxxx>
> > CC: Yasuaki Ishimatsu <isimatu.yasuaki@xxxxxxxxxxxxxx>
> > Signed-off-by: Wen Congyang <wency@xxxxxxxxxxxxxx>
> > Reviewed-by: Yasuaki Ishimatsu <isimatu.yasuaki@xxxxxxxxxxxxxx>
> > ---
> >   drivers/acpi/acpi_memhotplug.c |    4 ++++
> >   1 files changed, 4 insertions(+), 0 deletions(-)
> >
> > diff --git a/drivers/acpi/acpi_memhotplug.c b/drivers/acpi/acpi_memhotplug.c
> > index 2a7beac..7873832 100644
> > --- a/drivers/acpi/acpi_memhotplug.c
> > +++ b/drivers/acpi/acpi_memhotplug.c
> > @@ -83,6 +83,7 @@ struct acpi_memory_info {
> >   struct acpi_memory_device {
> >       struct acpi_device * device;
> >       unsigned int state;    /* State of the memory device */
> > +    int nid;
> >       struct list_head res_list;
> >   };
> > @@ -256,6 +257,9 @@ static int acpi_memory_enable_device(struct acpi_memory_device *mem_device)
> >           info->enabled = 1;
> >           num_enabled++;
> >       }
> > +
> > +    mem_device->nid = node;
> > +
> >       if (!num_enabled) {
> >           printk(KERN_ERR PREFIX "add_memory failed\n");
> >           mem_device->state = MEMORY_INVALID_STATE;


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/