Re: [PATCH v2 6/7] usb: dwc3-omap: Minor fixes to get dt working

[Sergei Shtylyov]

Hello.

On 01-10-2012 12:25, Kishon Vijay Abraham I wrote:

> Includes few minor fixes in dwc3-omap like populating the compatible
> string in a correct way, extracting the utmi-mode property properly and
> changing the index of get_irq since irq of core is removed from hwmod
> entry.
> Also updated the documentation with dwc3-omap device tree binding
> information.
>
> Signed-off-by: Kishon Vijay Abraham I<kishon@xxxxxx>
> ---
>   drivers/usb/dwc3/dwc3-omap.c |    8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/usb/dwc3/dwc3-omap.c b/drivers/usb/dwc3/dwc3-omap.c
> index c19affa..25bd847 100644
> --- a/drivers/usb/dwc3/dwc3-omap.c
> +++ b/drivers/usb/dwc3/dwc3-omap.c
> @@ -277,13 +277,13 @@ static int __devinit dwc3_omap_probe(struct platform_device *pdev)
>
>   	platform_set_drvdata(pdev, omap);
>
> -	irq = platform_get_irq(pdev, 1);
> +	irq = platform_get_irq(pdev, 0);
>   	if (irq<  0) {
>   		dev_err(dev, "missing IRQ resource\n");
>   		return -EINVAL;
>   	}
>
> -	res = platform_get_resource(pdev, IORESOURCE_MEM, 1);
> +	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>   	if (!res) {
>   		dev_err(dev, "missing memory base resource\n");
>   		return -EINVAL;
> @@ -326,7 +326,7 @@ static int __devinit dwc3_omap_probe(struct platform_device *pdev)
>
>   	utmi_mode = of_get_property(node, "utmi-mode",&size);
>   	if (utmi_mode&&  size == sizeof(*utmi_mode)) {
> -		reg |= *utmi_mode;
> +		reg |= be32_to_cpup(utmi_mode);

   Why not just use of_property_read_u32() instead of all this?

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/