Re: [PATCH 1/2] net: ethernet: clean out braces / old code (foundvia checkpatch)

[David Miller]

From: matthew@xxxxxxxxxxx
Date: Tue,  2 Oct 2012 12:41:44 +0100

> From: Matthew Walster <matthew@xxxxxxxxxxx>
> 
> Remove an old commented out piece of code.
> Remove an if(true) statement.
> Remove a set of braces that weren't strictly necessary.
> 
> All found by running checkpatch.pl against the code.
> 
> Signed-off-by: Matthew Walster <matthew@xxxxxxxxxxx>

That comment and that unconditional if() are documentation.

Don't be an automaton and blindly make changes based upon
checkpatch.pl output.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/