Re: UBI: Fastmap request for inclusion (v19)

[Artem Bityutskiy]

On Wed, 2012-10-03 at 14:05 +0300, Artem Bityutskiy wrote:
> On Wed, 2012-10-03 at 10:36 +0200, Richard Weinberger wrote:
> > Am Wed, 03 Oct 2012 11:25:45 +0300
> > schrieb Artem Bityutskiy <artem.bityutskiy@xxxxxxxxxxxxxxx>:
> > 
> > > On Wed, 2012-09-26 at 17:51 +0200, Richard Weinberger wrote:
> > > > UBI Fastmap is an optional feature which stores the physical to
> > > > logical eraseblock relations in a checkpoint (called fastmap) to
> > > > reduce the initialization time of UBI. The current init time of UBI
> > > > is proportional to the number of physical erase blocks on the FLASH
> > > > device. With fastmap enabled the scan time is limited to a fixed
> > > > number of blocks.
> > > 
> > > Aiaiai complains and linux-next build fails :-( Last time I forgot to
> > > enable the fastmap kbuild option so aiaiai checked with that option
> > > disabled. Now I enabled it with a simple hack (default n -> default y)
> > > and here are aiaiai's complaints - there is a build failure for
> > > ARCH=i386.
> > 
> > Build fix for linux-next is on the way into your inbox.
> > I'm currently looking at the aiaiai output.
> 
> It did not help. I still get:
> 
> ERROR: "ubi_update_fastmap" [drivers/mtd/ubi/ubi.ko] undefined!
> ERROR: "ubi_scan_fastmap" [drivers/mtd/ubi/ubi.ko] undefined!
> ERROR: "ubi_calc_fm_size" [drivers/mtd/ubi/ubi.ko] undefined!
> 
> Please, see branch 'linux-next' in UBI to see what I actually tested.

And aiaiai has another correct complaint:

+drivers/mtd/ubi/fastmap.c:1078 ubi_scan_fastmap() warn: possible memory leak of 'fm' [smatch]

-- 
Best Regards,
Artem Bityutskiy

Attachment: signature.asc
Description: This is a digitally signed message part