Re: [PATCH 06/13] scripts/gdb: Add lx-dmesg command

[Jan Kiszka]

On 2012-10-03 14:16, Andi Kleen wrote:
> Jan Kiszka <jan.kiszka@xxxxxx> writes:
> 
>> From: Jan Kiszka <jan.kiszka@xxxxxxxxxxx>
>>
>> This pokes into the log buffer of the debugged kernel, dumping it to the
>> gdb console. Helping in case the target should or can no longer execute
>> dmesg itself.
> 
> Thanks. That's very useful. I recently ran into this problem that
> the new log buffer is a pain to dump from qemu gdb.
> 
> fwiw there's already some kdump macros in Documentation/kdump 
> Since you obsoleted them you could remove those (and for log buffer
> they do not work anymore)

Oh, indeed - and pretty dusty now. I would suggest to remove it when all
its feature are either broken or replaced by python scripts. Need to
look at the details, but stack backtraces is definitely still on the
todo list here.

> 
> I don't like the lx-* prefixes.

In this case I think we could add the feature also under "dmesg". But I
would generally like to avoid potential namespace clashes with gdb or
other helpers, therefore the common prefix. Also, if you type
"lx-<tab>", you now get a list of all Linux-related commands.

Jan

Attachment: signature.asc
Description: OpenPGP digital signature