Re: udev breakages - was: Re: Need of an ".async_probe()" type ofcallback at driver's core - Was: Re: [PATCH] [media] drxk: change it to use request_firmware_nowait()
From: Linus Torvalds
Date: Wed Oct 03 2012 - 12:55:58 EST
On Wed, Oct 3, 2012 at 8:13 AM, Mauro Carvalho Chehab
<mchehab@xxxxxxxxxx> wrote:
>
> Yes. The issue was noticed with media drivers when people started using the
> drivers on Fedora 17, witch came with udev-182. There's an open
> bugzilla there:
> https://bugzilla.redhat.com/show_bug.cgi?id=827538
Yeah, that bugzilla shows the problem with Kay as a maintainer too,
not willing to own up to problems he caused.
Can you actually see the problem? I did add the attached patch as an
attachment to the bugzilla, so the reporter there may be able to test
it, but it's been open for a long while..
Anyway. Attached is a really stupid patch that tries to do the "direct
firmware load" as suggested by Ivan. It has not been tested very
extensively at all (but I did test that it loaded the brcmsmac
firmware images on my laptop so it has the *potential* to work).
It has a few extra printk's sprinkled in (to show whether it does
anything or not), and it has a few other issues, but it might be worth
testing as a starting point.
We are apparently better off trying to avoid udev like the plague.
Doing something very similar to this for module loading is probably a
good idea too.
I'm adding Ming Lei to the participants too, because hooking into the
firmware loader like this means that the image doesn't get cached.
Which is sad. I'm hoping Ming Lei might be open to trying to fix that.
Hmm?
Linus
Attachment:
patch.diff
Description: Binary data