Re: [RFC 1/3] mfd: da9052-core: Use regmap_irq_get_virq() and fixthe probe

[Mark Brown]

On Wed, Oct 03, 2012 at 02:06:57PM -0300, Fabio Estevam wrote:

> +	/* Allocate a virtual IRQ domain to distribute to the regmap domains */
> +	da9052->virq = irq_domain_add_linear(NULL, ARRAY_SIZE(da9052_irqs),
> +						&da9052_domain_ops, da9052);
> +	if (!da9052->virq) {
> +		ret = -EINVAL;
> +		goto regmap_err;
> +	}

I still don't understand what on earth this is doing, as far as I can
tell there's only one domain in the device so you're not distrubting
anything between domains and there's as many interrupts in this domain
as there are in the domain allocated by regmap which is even odder.

There doesn't seem to be anything about this driver that's unusual, why
does it need this weird code?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/