Re: [PATCH] slub: init_kmem_cache_cpus() and put_cpu_partial() canbe static

[David Rientjes]

On Wed, 3 Oct 2012, Christoph Lameter wrote:

> > > Acked-by: Glauber Costa <glommer@xxxxxxxxxxxxx>
> > > Signed-off-by: Fengguang Wu <fengguang.wu@xxxxxxxxx>
> >
> > Acked-by: David Rientjes <rientjes@xxxxxxxxxx>
> >
> > I think init_kmem_cache_cpus() would also benefit from just being inlined
> > into alloc_kmem_cache_cpus().
> 
> The compiler will do that if it is advantageous.
> 

Which it obviously does with -O2, but I think it would be advantageous to 
do this at the source code level as well since we have a function with a 
single caller, which happens to be marked inline itself, but we're not 
inline.  It seems cleaner to me, but it's only a suggestion.  Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/