Re: [PATCH] USB: input: wacom_sys.c: format OLED image in kernel

[Przemo Firszt]

Dnia 4 Października 2012, 8:25 am, Cz, Dmitry Torokhov napisał(a):
> Hi Przemo,
Hi Dmitry,
>
> On Sun, Sep 09, 2012 at 03:37:18PM -0400, Przemo Firszt wrote:
>> This patch adds a new way of handling Wacom Intuos4 family OLEDs.
>> Previously the images had to be 'scrambled' by userland application. Now
>> the 'scrambling' is done in the kernel module, so user space can send
>> simple 64x32 pixels 4-bit grayscale (2 pixels per byte) 0,0 in top left
>> corner
>> images straight to a wacom OLED sysfs entry. An example:
>>
>> dd bs=1024 if=image_file \
>> of=/sys/bus/usb/drivers/wacom/[DevNo]/wacom_led/button[No]_formattedimg
>> \
>> count=1
>>
>> This patch greatly simplifies user space preparation of the image.
>> The raw image sysfs enties are still present to avoid breaking API.
>
> I do not not believe that we should add code to the kernel for tasks that
> can be just as easily performed in userspace.
>
> Thanks!
>
> --
> Dmitry
>
OK, thanks for the explanation!

-- 
Regards,
Przemo Firszt

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/