Re: [PATCH] btrfs ulist use rbtree instead

[David Sterba]

> @@ -207,16 +266,23 @@ EXPORT_SYMBOL(ulist_add);
>   * end is reached. No guarantee is made with respect to the order in which
>   * the elements are returned. They might neither be returned in order of
>   * addition nor in ascending order.
> - * It is allowed to call ulist_add during an enumeration. Newly added items
> - * are guaranteed to show up in the running enumeration.
>   */
>  struct ulist_node *ulist_next(struct ulist *ulist, struct ulist_iterator *uiter)

Quick observation:

If there's code relying on the behaviour stated in the removed part of
the comment, it will break. Have you verified this is not the case?


david
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/