Re: [ 022/180] ioat2: kill pending flag

[Ben Hutchings]

On Tue, 2012-10-02 at 00:52 +0200, Willy Tarreau wrote:
> 2.6.32-longterm review patch.  If anyone has any objections, please let me know.
> 
> ------------------
> 
> From: Dan Williams <dan.j.williams@xxxxxxxxx>
> 
> commit 281befa5592b0c5f9a3856b5666c62ac66d3d9ee upstream.
> 
> The pending == 2 case no longer exists in the driver so, we can use
> ioat2_ring_pending() outside the lock to determine if there might be any
> descriptors in the ring that the hardware has not seen.
[...]

What bug does this fix?  Is ioat2_ring_pending() *really* safe to call
without the ring_lock?

Ben.

-- 
Ben Hutchings
For every complex problem
there is a solution that is simple, neat, and wrong.

Attachment: signature.asc
Description: This is a digitally signed message part