RE: [PATCH 1/5] rapidio: fix blocking wait for discovery ready

From: Bounine, Alexandre
Date: Thu Oct 04 2012 - 13:20:30 EST


On Wed, October 03, 2012 6:20 PM
Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:
>
> On Wed, 3 Oct 2012 15:18:39 -0400
> Alexandre Bounine <alexandre.bounine@xxxxxxx> wrote:
>
> > Fix blocking wait loop in the RapidIO discovery routine to avoid
> > warning dumps about stalled CPU on x86 platforms.
> >
> > ...
> >
> > + to_end = jiffies + CONFIG_RAPIDIO_DISC_TIMEOUT * HZ;
> > + while (time_before(jiffies, to_end)) {
> > + if (rio_enum_complete(mport))
> > + goto enum_done;
> > +
> schedule_timeout_uninterruptible(msecs_to_jiffies(10));
>
> I think a simple msleep(10) would suffice here?
>
Agree, same thing but looks simpler. Will update.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/