Re: [PATCH] ARM: Push selects for TWD/SCU into machine entries

[Santosh Shilimkar]

On Friday 05 October 2012 06:42 AM, Simon Horman wrote:
> On Thu, Oct 04, 2012 at 02:41:46PM +0530, Santosh Shilimkar wrote:
> > On Thursday 04 October 2012 02:20 PM, Stephen Boyd wrote:
> > > The TWD and SCU configs are selected by default as long as
> > > SCORPIONMP is false and/or MCT is false. Implementing the logic
> > > this way certainly saves lines in the Kconfig but it precludes
> > > those machines which select SCORPIONMP or MCT from participating
> > > in the single zImage effort because when those machines are
> > > combined with other SMP capable machines the TWD and SCU are no
> > > longer selected.
> > >
> > > Push the select out to the machine entries so that we can compile
> > > these machines together and still select the appropriate configs.
> > >
> > > Signed-off-by: Stephen Boyd<sboyd@xxxxxxxxxxxxxx>
> > > Cc: David Brown<davidb@xxxxxxxxxxxxxx>
> > > Cc: Kukjin Kim<kgene.kim@xxxxxxxxxxx>
> > > Cc: Linus Walleij<linus.walleij@xxxxxxxxxx>
> > > Cc: Pawel Moll<pawel.moll@xxxxxxx>
> > > Cc: Rob Herring<rob.herring@xxxxxxxxxxx>
> > > Cc: Russell King<linux@xxxxxxxxxxxxxxxx>
> > > Cc: Sascha Hauer<kernel@xxxxxxxxxxxxxx>
> > > Cc: Shiraz Hashim<shiraz.hashim@xxxxxx>
> > > Cc: Simon Horman<horms@xxxxxxxxxxxx>
> > > Cc: Srinidhi Kasagar<srinidhi.kasagar@xxxxxxxxxxxxxx>
> > > Cc: Stephen Warren<swarren@xxxxxxxxxxxxx>
> > > Cc: Tony Lindgren<tony@xxxxxxxxxxx>
> > > Cc: Viresh Kumar<viresh.linux@xxxxxxxxx>
> > > ---
> > >
> > > Does OMAP5 need to select TWD? I suspect not if it uses the
> > > architected timers.
> > Nope. OMAP5 don't use TWD. Infact the external SCU is also used
> > for A9 SOCs. You might want to check other A15 SOCS for SCU as
> > well.
>
> In that case I am a bit confused by the following result:
>
> # git checkout v3.6
> # ARCH=arm make omap2plus_defconfig
> # grep '(SOC_OMAP5|_SCU|_TWD|CONFIG_SMP|CONFIG_LOCAL_TIMERS)=' .config
> CONFIG_SOC_OMAP5=y
> CONFIG_SMP=y
> CONFIG_HAVE_ARM_SCU=y
> CONFIG_HAVE_ARM_TWD=y
> CONFIG_LOCAL_TIMERS=y

Thats because omap2plus_defconfig build all the OMAP machines together
including OMAP4 and OMAP5.

Regards
Santosh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/