Re: [PATCH 19/20] drivers/net/ethernet/marvell/skge.c: fix errorreturn code

From: Dan Carpenter
Date: Fri Oct 05 2012 - 04:02:29 EST


On Fri, Oct 05, 2012 at 12:36:35AM -0700, Joe Perches wrote:
> On Fri, 2012-10-05 at 07:22 +0200, Julia Lawall wrote:
> > A tool was used to find a potential problem, and then Peter
> > studied the code to see what fix was appropriate.
>
> Hi Julia.
>
> Was it true that a static analysis tool found the original
> potential issue? If so, what tool was it?
>
> But wasn't the scripted fix applied to the rest of the tree
> robotically?

It was coccinelle. It just prints a warning. You have to go in
manually, review the code and pick the correct error code.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/