Re: [PATCH 1/7] uprobes/x86: Only rep+nop can be emulated correctly

[Srikar Dronamraju]

* Oleg Nesterov <oleg@xxxxxxxxxx> [2012-09-30 21:41:58]:

> __skip_sstep() correctly detects the "nontrivial" nop insns,
> but since it doesn't update regs->ip we can not really skip
> "0x0f 0x1f | 0x0f 0x19 | 0x87 0xc0", the probed application
> is killed by SIGILL'ed handle_swbp().
> 
> Remove these additional checks. If we want to implement this
> correctly we need to know the full insn length to update ->ip.
> 
> rep* + nop is fine even without updating ->ip.
> 
> Signed-off-by: Oleg Nesterov <oleg@xxxxxxxxxx>
> ---

Acked-by: Srikar Dronamraju <srikar@xxxxxxxxxxxxxxxxxx>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/