Re: [RFC PATCH 02/06] input/rmi4: Core files

[devendra.aaru]

On Sat, Oct 6, 2012 at 9:06 AM, devendra.aaru <devendra.aaru@xxxxxxxxx> wrote:
> On Sat, Oct 6, 2012 at 8:19 AM, Joe Perches <joe@xxxxxxxxxxx> wrote:
>> On Fri, 2012-10-05 at 21:09 -0700, Christopher Heiny wrote:
>> []
>>
>> Just some trivial comments:
>>
>>> diff --git a/drivers/input/rmi4/rmi_driver.c b/drivers/input/rmi4/rmi_driver.c
>> []
>>> @@ -0,0 +1,1529 @@
>> []
>>> +static ssize_t delay_write(struct file *filp, const char __user *buffer,
>>> +                        size_t size, loff_t *offset) {
>>> +     struct driver_debugfs_data *data = filp->private_data;
>>> +     struct rmi_device_platform_data *pdata =
>>> +                     data->rmi_dev->phys->dev->platform_data;
>>> +     int retval;
>>> +     char local_buf[size];
>>> +     unsigned int new_read_delay;
>>> +     unsigned int new_write_delay;
>>> +     unsigned int new_block_delay;
>>> +     unsigned int new_pre_delay;
>>> +     unsigned int new_post_delay;
>>> +
>>> +     retval = copy_from_user(local_buf, buffer, size);
>>> +     if (retval)
>>> +             return -EFAULT;
>>> +
>>> +     retval = sscanf(local_buf, "%u %u %u %u %u", &new_read_delay,
>>> +                     &new_write_delay, &new_block_delay,
>>> +                     &new_pre_delay, &new_post_delay);
>>> +     if (retval != 5) {
>>> +             dev_err(&data->rmi_dev->dev,
>>> +                     "Incorrect number of values provided for delay.");
>>> +             return -EINVAL;
>>> +     }
>>> +     if (new_read_delay < 0) {
>>
>> These are unnecessary tests as unsigned values are never < 0.
>>
>
Oops, i m sorry, i mistakenly took the variable as int, it should be
unsinged int.

sorry joe, you are right the are never < 0.

 Thanks,
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/