Re: [PATCH v2] gma500: medfield: drop bogus NULL check inmdfld_dsi_output_init()

[Kirill A. Shutemov]

On Mon, Oct 08, 2012 at 10:44:06PM +0800, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@xxxxxxxxxxxxxxxxx>
> 
> Drop the NULL test for dev since it never be NULL.
> 
> dpatch engine is used to auto generate this patch.
> (https://github.com/weiyj/dpatch)
> 
> Signed-off-by: Wei Yongjun <yongjun_wei@xxxxxxxxxxxxxxxxx>
> ---
>  drivers/gpu/drm/gma500/mdfld_dsi_output.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/gma500/mdfld_dsi_output.c b/drivers/gpu/drm/gma500/mdfld_dsi_output.c
> index 32dba2a..b6f49d9 100644
> --- a/drivers/gpu/drm/gma500/mdfld_dsi_output.c
> +++ b/drivers/gpu/drm/gma500/mdfld_dsi_output.c
> @@ -506,7 +506,7 @@ void mdfld_dsi_output_init(struct drm_device *dev,
>  
>  	dev_dbg(dev->dev, "init DSI output on pipe %d\n", pipe);
>  
> -	if (!dev || ((pipe != 0) && (pipe != 2))) {
> +	if ((pipe != 0) && (pipe != 2)) {

It would be nice to remove redundant parentheses while you're there.

Otherwise
Acked-by: Kirill A. Shutemov <kirill.shutemov@xxxxxxxxxxxxxxx>

>  		DRM_ERROR("Invalid parameter\n");
>  		return;
>  	}
> 
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

-- 
 Kirill A. Shutemov
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/