Re: [PATCH V2 4/4] regulator: tps65090: add external control supportfor DCDC

[Stephen Warren]

On 10/09/2012 04:33 AM, Venu Byravarasu wrote:
> Laxman Dewangan wrote at Tuesday, October 09, 2012 3:19 PM:
>> The TPS65090's DCDC output can also be enable/disable through the
>> external digital input signal. Add support for enable/disable
>> either through register access via I2C or through external
>> control inputs. The external control inputs can be driven through
>> GPIOs also and hence adding support for passing the GPIO number.

>> -static struct regulator_ops tps65090_ops = {
>> -	.enable = regulator_enable_regmap,
>> -	.disable = regulator_disable_regmap,
>> -	.is_enabled = regulator_is_enabled_regmap,
>> +static struct regulator_ops tps65090_ext_control_ops = {
>> +};
> 
> What is the purpose of adding empty structure?

When replying to a patch (or email in general), it's usually a good idea
to delete stuff that you're not replying to. Otherwise, it can be hard
to find the replies since they're buried in a huge long email.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/