Re: [PATCH 2/3] lglock: make the per_cpu locks static

[Andrew Morton]

On Tue, 9 Oct 2012 11:46:39 +0800
Lai Jiangshan <laijs@xxxxxxxxxxxxxx> wrote:

> The per_cpu locks are not used outside nor exported.
> Add a "static" linkage keyword to it.

I think a better description is:

: The per_cpu locks are not used outside the file which contains the
: DEFINE_LGLOCK(), so we can make these symbols static.

> --- a/include/linux/lglock.h
> +++ b/include/linux/lglock.h
> @@ -49,7 +49,7 @@ struct lglock {
>  };
>  
>  #define DEFINE_LGLOCK(name)						\
> -	DEFINE_PER_CPU(arch_spinlock_t, name ## _lock)			\
> +	static DEFINE_PER_CPU(arch_spinlock_t, name ## _lock)		\
>  	= __ARCH_SPIN_LOCK_UNLOCKED;					\
>  	struct lglock name = { .lock = &name ## _lock }
>  
> -- 
> 1.7.4.4
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/