Re: [PATCH] x86: Switch to vga console only if framebuffer detailsare missing

[Matt Fleming]

On Mon, 2012-09-17 at 11:29 +0100, Matt Fleming wrote:
> From: Matt Fleming <matt.fleming@xxxxxxxxx>
> 
> The efi_enabled variable has come to mean "Do we have EFI runtime
> services available?". However, lack of EFI runtime services does not
> mean that we should switch to using the VGA console. Provided that the
> boot loader passed the dimensions of the EFI framebuffer there is no
> reason we can't use efifb.
> 
> There's also no reason to check the memory type of 0xa0000 - whether
> or not that memory region is EFI_CONVENTIONAL_MEMORY is immaterial -
> the EFI framebuffer device will still work, and checking the EFI
> memory type of a memory region on a non-EFI machine is illogical.
> 
> Cc: H. Peter Anvin <hpa@xxxxxxxxx>
> Cc: Matthew Garrett <mjg@xxxxxxxxxx>
> Cc: Olof Johansson <olof@xxxxxxxxx>
> Cc: Peter Jones <pjones@xxxxxxxxxx>
> Cc: Ingo Molnar <mingo@xxxxxxxxxx>
> Signed-off-by: Matt Fleming <matt.fleming@xxxxxxxxx>
> ---
>  arch/x86/kernel/setup.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)

Ping? Anybody got an opinion on this one?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/