Re: [PATCH 1/2] tracing: trivial cleanup

From: Borislav Petkov
Date: Fri Oct 12 2012 - 02:20:23 EST


On Thu, Oct 11, 2012 at 10:42:26PM -0400, Steven Rostedt wrote:
> On Thu, 2012-10-11 at 19:31 -0700, David Sharp wrote:
> > On Thu, Oct 11, 2012 at 6:56 PM, Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:
> > > Sorry, I know this is late, but it was pushed down in my todo list
> > > (never off, but something I probably wouldn't have seen for a few more
> > > months).
> > >
> > > On Thu, 2012-06-07 at 16:46 -0700, Vaibhav Nagarnaik wrote:
> > >> From: David Sharp <dhsharp@xxxxxxxxxx>
> > >
> > > If this is from David it needs his SOB.
> >
> > Is that true even though we are working for the same company?
> >
>
> Yes.
>
> I would never push a patch from Ingo without his Signed-off-by even
> though he and I work for the same company ;-)
>
> Although, the GPL would let you. But it's best not to do it.

I'd say that it is even a no-no. The SOB chain denotes author - possible
intermediary handler as in this case - committer and we all feel very
strongly (I'm told :-)) about stating the exact origin and path upstream
of every patch. So it is not only an authorship issue.

--
Regards/Gruss,
Boris.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/